This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] Linux Kernel Markers 0.2 for Linux 2.6.17
- From: "S. P. Prasanna" <prasanna at in dot ibm dot com>
- To: Mathieu Desnoyers <mathieu dot desnoyers at polymtl dot ca>
- Cc: linux-kernel at vger dot kernel dot org, Christoph Hellwig <hch at infradead dot org>, Andrew Morton <akpm at osdl dot org>, Ingo Molnar <mingo at redhat dot com>, Greg Kroah-Hartman <gregkh at suse dot de>, Thomas Gleixner <tglx at linutronix dot de>, Douglas Niehaus <niehaus at eecs dot ku dot edu>, Tom Zanussi <zanussi at us dot ibm dot com>, Paul Mundt <lethal at linux-sh dot org>, Jes Sorensen <jes at sgi dot com>, Richard J Moore <richardj_moore at uk dot ibm dot com>, William Cohen <wcohen at redhat dot com>, "Martin J. Bligh" <mbligh at mbligh dot org>, Michel Dagenais <michel dot dagenais at polymtl dot ca>, systemtap at sources dot redhat dot com, ltt-dev at shafik dot org
- Date: Tue, 19 Sep 2006 14:09:00 +0530
- Subject: Re: [PATCH] Linux Kernel Markers 0.2 for Linux 2.6.17
- References: <20060919183447.GA16095@Krystal>
- Reply-to: prasanna at in dot ibm dot com
On Tue, Sep 19, 2006 at 02:34:47PM -0400, Mathieu Desnoyers wrote:
[....]
> --- /dev/null
> +++ b/kernel/Kconfig.marker
> @@ -0,0 +1,75 @@
> +# Code markers configuration
> +
> +menu "Marker configuration"
> +
> +
> +config MARK
> + bool "Enable MARK code markers"
> + default y
> + help
> + Activate markers that can call printk or can be instrumented
> + dynamically.
> +
> +choice
> + prompt "MARK code marker behavior"
> + default MARK_KPROBE
> + depends on MARK
> + help
> + Configuration of markers that can call printk or can be
> + instrumented dynamically.
> +
> +config MARK_KPROBE
> + bool "KPROBE"
> + ---help---
> + Change markers for a symbol "__mark_modulename_event".
> +config MARK_JPROBE
> + bool "JPROBE"
> + ---help---
> + Change markers for a symbol "__mark_modulename_event"
> + and create a target for a high speed dynamic probe.
> +config MARK_FPROBE
> + bool "FPROBE"
> + ---help---
> + Change markers for a function call.
> +config MARK_PRINT
> + bool "PRINT"
> + ---help---
> + Call printk from the marker.
> +endchoice
> +
> +config MARK_NOPRINT
> + bool "Enable MARK_NOPRINT code markers"
> + default y
> + help
> + Activate markers that cannot call printk.
> +
> +choice
> + prompt "MARK_NOPRINT code marker behavior"
> + default MARK_NOPRINT_KPROBE
> + depends on MARK_NOPRINT
> + help
> + Configuration of markers that cannot call printk.
> +
> +config MARK_NOPRINT_KPROBE
> + bool "KPROBE"
> + ---help---
> + Change markers for a symbol "__mark_modulename_event".
> +config MARK_NOPRINT_JPROBE
> + bool "JPROBE"
> + ---help---
> + Change markers for a symbol "__mark_modulename_event"
> + and create a target for a high speed dynamic probe.
> +config MARK_NOPRINT_FPROBE
> + bool "FPROBE"
> + ---help---
> + Change markers for a function call.
> +endchoice
> +
> +config MARK_STATIC
> + bool "Enable MARK_STATIC code markers"
> + default n
> + help
> + Activate markers that cannot be instrumented dynamically. They will
> + generate function calls to each function-style probe.
> +
> +endmenu
I think having so many config options is not a good idea, you can group them
and reduce the number of config options.
Thanks
Prasanna
--
Prasanna S.P.
Linux Technology Center
India Software Labs, IBM Bangalore
Email: prasanna@in.ibm.com
Ph: 91-80-41776329