This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: ioblock.stp major/minor number patch
- From: fche at redhat dot com (Frank Ch. Eigler)
- To: Mike Mason <mmlnx at us dot ibm dot com>
- Cc: SystemTAP <systemtap at sources dot redhat dot com>
- Date: 23 Oct 2006 11:56:01 -0400
- Subject: Re: ioblock.stp major/minor number patch
- References: <453CE190.3060406@us.ibm.com>
Mike Mason <mmlnx@us.ibm.com> writes:
> The following patch adds major/minor number functions to the ioblock
> tapset. I found them useful in a block IO script I'm writing.
Good stuff, it's especially nice to see the deref() protection.
To complete the work, the new functions will need documentation
in one of the stapprobes* man pages, and test case or two.
(Something triggering those deref_faults too please.)
> It also fixes a few misleading comments.
It sounds like you should get yourself CVS access so that you can
check in small & obvious things like that. (See the web site for
details.)
- FChE