This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Generic test suite failures found with ARM testing
- From: Quentin Barnes <qbarnes at urbana dot css dot mot dot com>
- To: systemtap at sources dot redhat dot com
- Date: Wed, 13 Jun 2007 15:50:50 -0500
- Subject: Generic test suite failures found with ARM testing
I've run across two test failures on ARM that are not ARM-specific. They
are with systemtap.samples/profile.exp and systemtap.samples/syscalls2.exp.
These tests fail for me because of the 128 character limit on strings.
For example, with profile.exp the output being looked for is truncated:
staprun(4619) kernel.function("sys_poll@/proj/cost/work/qbarnes/kprobes/work/usr/src/linux-2.6.21.4/fs/select.c:742").call coun^M
For example, with syscalls2.exp the output just keeps being appended to
losing the newlines so less than expected 100 lines show up:
5056 kernel.function("sys_oabi_socketcall@/proj/cost/work/qbarnes/kprobes/work/usr/src/linux-2.6.21.4/arch/arm/kernel/sys_oabi-5056 kernel.function("sys_oabi_sendto@/proj/cost/work/qbarnes/kprobes/work/usr/src/linux-2.6.21.4/arch/arm/kernel/sys_oabi-comp5056 kernel.function("sys_sendto@/proj/cost/work/qbarnes/kprobes/work/usr/src/linux-2.6.21.4/net/socket.c:1538").call^M
What's the best fix here? I see a few choices:
1) Don't build your kernel deeper than a few levels of directories
and expect the tests to work.
2) Up the max string length parameter MAXSTRINGLEN to be more robust.
3) Modify these tests not to output the path with the function name.
4) Something I didn't think of.
What would be the preferred solution here?
Quentin