This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] For avoid stap output error message of un-defined variable twice

From: fche at redhat dot com (Frank Ch. Eigler)
To: "Zhaolei" <zhaolei at cn dot fujitsu dot com>
Cc: <systemtap at sourceware dot org>
Date: Fri, 17 Aug 2007 13:29:24 -0400
Subject: Re: [patch] For avoid stap output error message of un-defined variable twice
References: <010c01c7dfa6$b121b550$85697c0a@guest004> <0d0101c7e09b$72ac0fa0$85697c0a@guest004>

"Zhaolei" <zhaolei@cn.fujitsu.com> writes:

> I tried using un-defined variable in print function as mentioned in CaiFei's 
> mail in Fri, 17 Aug 2007 10:39:07 +0900.
> And I found that error message had been displayed twice.
>[...]

Good catch!  Looking over elaborate.cxx, it seems that all code nearby
should be converted to use the newer duplicate elimination logic found
in session::print_error.  I committed a patch to that effect.  (If you
find other such bugs, a similar approach should work.  There should be
only a few direct references to cerr in the sources.)

- FChE

References:
- [patch] Improve _sock_family_str's sock_family string to tapset
  - From: Zhaolei
- [patch] For avoid stap output error message of un-defined variable twice
  - From: Zhaolei

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]