This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -mm 1/5] list.h: add list_singleton
- From: Masami Hiramatsu <mhiramat at redhat dot com>
- To: Peter Zijlstra <a dot p dot zijlstra at chello dot nl>
- Cc: Andrew Morton <akpm at linux-foundation dot org>, ananth at in dot ibm dot com, jkenisto at us dot ibm dot com, linux-kernel at vger dot kernel dot org, systemtap at sources dot redhat dot com, prasanna at in dot ibm dot com, shaohua dot li at intel dot com, davem at davemloft dot net, fche at redhat dot com
- Date: Mon, 17 Mar 2008 11:04:16 -0400
- Subject: Re: [PATCH -mm 1/5] list.h: add list_singleton
- References: <47DAE2C4.2060303@redhat.com> <20080314140007.a7b495d7.akpm@linux-foundation.org> <47DAFAA2.20302@redhat.com> <1205620596.6422.8.camel@lappy>
Hi Peter,
Peter Zijlstra wrote:
>>> So I guess we can proceed with your list_singleton(), but I'd just like to
>>> flag this possible confusion, see what people think..
>
> May I kindly ask to please not use the singleton name like this. It does
> not implement the singleton pattern and will be a great confusion for
> everybody who expects it to.
Indeed.
I have some other candidates.
- list_single
- list_has_one
- list_one
Could you tell me which or some other name you recommend?
Thanks,
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com