This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Re: [PATCH] usb-storage: don't call utsname()

From: "Steve French (smfltc)" <smfltc at us dot ibm dot com>
To: Greg KH <greg at kroah dot com>
Cc: Alan Stern <stern at rowland dot harvard dot edu>, Matthew Dharm <mdharm-usb at one-eyed-alien dot net>, Christoph Hellwig <hch at infradead dot org>, "Frank Ch. Eigler" <fche at redhat dot com>, Adrian Bunk <bunk at kernel dot org>, USB Storage list <usb-storage at lists dot one-eyed-alien dot net>, Kernel development list <linux-kernel at vger dot kernel dot org>, "David S. Miller" <davem at sunset dot davemloft dot net>, systemtap at sources dot redhat dot com, Andrew Morton <akpm at linux-foundation dot org>, linux-cifs-client at lists dot samba dot org, linux-nfs at vger dot kernel dot org
Date: Wed, 21 May 2008 13:19:32 -0500
Subject: Re: Re: [PATCH] usb-storage: don't call utsname()
References: <20080521123700.GA8770@infradead.org> <Pine.LNX.4.44L0.0805211349480.3409-100000@iolanthe.rowland.org> <20080521180957.GA17598@kroah.com>

Greg KH wrote:

On Wed, May 21, 2008 at 01:51:17PM -0400, Alan Stern wrote:
This patch (as1100) replaces the core-kernel function call to utsname()
in usb-storage with the UTS_RELEASE macro.  It's used only for warning
about extra unusual_devs entries.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Why?  With this change, if you change the version number, the file will
have to be rebuilt.  Without the change, the file will not need to be
rebuilt, right?
I thought that was why this change was made a while ago, to prevent things from having to be rebuilt that didn't need to be

I agree - what was wrong with utsname->release ... it seems odd to statically build the kernel's version number into a module - it should be something we should be able to query (and it shouldn't change without reboot so accessing it is not racy). Access to other fields in the structure (nodename, domainname etc.) might need to be included in a macro but I didn't see one in utsname.h for this.

References:
- Re: [2.6 patch] unexport uts_sem
  - From: Christoph Hellwig
- [PATCH] usb-storage: don't call utsname()
  - From: Alan Stern
- Re: [PATCH] usb-storage: don't call utsname()
  - From: Greg KH

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]