This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC] [PATCH] Add statement ranges to kernel.statement

From: "Stone, Joshua I" <joshua dot i dot stone at intel dot com>
To: Stan Cox <scox at redhat dot com>
Cc: SystemTap List <systemtap at sources dot redhat dot com>
Date: Fri, 20 Jun 2008 15:25:48 -0700
Subject: Re: [RFC] [PATCH] Add statement ranges to kernel.statement
References: <1213989653.25984.15.camel@multics.rdu.redhat.com> <20080620221617.GA15073@jistone-expr.sc.intel.com>

Stone, Joshua I wrote:
> > +     if (line_type != WILDCARD && l == lines[1])
> > +       break;
> > +      }
> 
> I think this will break for relative probes, because the incoming
> lines[2] are relative, but 'l' is absolute.

Ouch - I just confused myself with this ambiguous wording.  By "this
will break" I mean that the condition won't work as intended, so in fact
this will not break (out of the loop).

Josh

References:
- [RFC] [PATCH] Add statement ranges to kernel.statement
  - From: Stan Cox
- Re: [RFC] [PATCH] Add statement ranges to kernel.statement
  - From: Stone, Joshua I

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]