This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCHv2 1/2] Fix semantic error: empty struct


Hi -

Thanks for the revised patch, looks good.  I have two questions.  Can
you explain why the "global_alias_cache" seems like it should be a
static member, rather than ordinary member of dwflpp?  (dwflpp
instances are relatively long-lived, and already have a formal cache
release mechanism.)

Also, doesn't it seem like the stap_compile{} dejagnu proc seems
unnecessarily complicated (like some other such functions in the
testsuite)?  You could just have your .exp file do

     spawn stap -p4 $srcdir/$subdir/script.stp
     expect { ... }
     close; wait

- FChE


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]