This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCHv2 1/2] Fix semantic error: empty struct
- From: fche at redhat dot com (Frank Ch. Eigler)
- To: James Bottomley <James dot Bottomley at HansenPartnership dot com>
- Cc: systemtap at sources dot redhat dot com
- Date: Tue, 08 Jul 2008 14:16:22 -0400
- Subject: Re: [PATCHv2 1/2] Fix semantic error: empty struct
- References: <1215539073.3214.26.camel@localhost.localdomain>
Hi -
Thanks for the revised patch, looks good. I have two questions. Can
you explain why the "global_alias_cache" seems like it should be a
static member, rather than ordinary member of dwflpp? (dwflpp
instances are relatively long-lived, and already have a formal cache
release mechanism.)
Also, doesn't it seem like the stap_compile{} dejagnu proc seems
unnecessarily complicated (like some other such functions in the
testsuite)? You could just have your .exp file do
spawn stap -p4 $srcdir/$subdir/script.stp
expect { ... }
close; wait
- FChE