This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCHv2 1/2] Fix semantic error: empty struct
- From: James Bottomley <James dot Bottomley at HansenPartnership dot com>
- To: "Frank Ch. Eigler" <fche at redhat dot com>
- Cc: systemtap at sources dot redhat dot com
- Date: Tue, 08 Jul 2008 13:30:04 -0500
- Subject: Re: [PATCHv2 1/2] Fix semantic error: empty struct
- Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=2007; t=1215541807; bh=PZIqDYTL8QCY/cf71Lzwx3F/8mqrx2PWh3G5sGJGyG o=; l=1113; h=Subject:From:To:Cc:In-Reply-To:References: Content-Type:Date:Message-Id:Mime-Version: Content-Transfer-Encoding; b=YSMqwwbfHHZLpKDQIoWyOiJowffjEj7RdUHcc zg9FGX1v1Inl1cLWq1cPMLwvYyoMRtb59GyAdJPrVL9t4WBaknlPDI7qSzhB1/bavGq oSQx3CHr5gY6Y7QtIPENI226wMzx3DrSxzf5MQpuerC7Iksa7/C42UFD+J9AmV91HAk =
- Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=2007; t=1215541805; bh=PZIqDYTL8QCY/cf71Lzwx3F/8mqrx2PWh3G5sGJGyG o=; l=1113; h=Subject:From:To:Cc:In-Reply-To:References: Content-Type:Date:Message-Id:Mime-Version: Content-Transfer-Encoding; b=rJ9obtFl9KF8vVWh/XHDNFZ8eX+VLh06p3CKe 1xv0CU4oX2dmbJ7T+x00+pXrHboA59l/OPjkqQ6FymVQmVMZdI4Sshy271MO3JOfsrV eTiIovYNVm4FIdBqazK2XDMOWUn3jclLAyMQwgBB0MGYS7yzL6oiRZcBBnnYkqKcFLA =
- References: <1215539073.3214.26.camel@localhost.localdomain> <y0mr6a4qm15.fsf@ton.toronto.redhat.com>
On Tue, 2008-07-08 at 14:16 -0400, Frank Ch. Eigler wrote:
> Hi -
>
> Thanks for the revised patch, looks good. I have two questions. Can
> you explain why the "global_alias_cache" seems like it should be a
> static member, rather than ordinary member of dwflpp? (dwflpp
> instances are relatively long-lived, and already have a formal cache
> release mechanism.)
you need a global cache for resolution ... it's not tied to any local
class instance. For class dwflpp it probably doesn't matter, since that
class is effectively static (by its survival for a session) but
logically because the DW_AT_declaration resolution is global, so should
the cache that does it.
> Also, doesn't it seem like the stap_compile{} dejagnu proc seems
> unnecessarily complicated (like some other such functions in the
> testsuite)? You could just have your .exp file do
>
> spawn stap -p4 $srcdir/$subdir/script.stp
> expect { ... }
> close; wait
perhaps it would be if I invented it. In fact, I just recycled it from
markers.exp, the declaration.exp just needed access.
James