This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCHv2 1/2] Fix semantic error: empty struct

From: David Smith <dsmith at redhat dot com>
To: "Frank Ch. Eigler" <fche at redhat dot com>
Cc: James Bottomley <James dot Bottomley at HansenPartnership dot com>, systemtap at sources dot redhat dot com
Date: Tue, 08 Jul 2008 15:58:19 -0500
Subject: Re: [PATCHv2 1/2] Fix semantic error: empty struct
References: <1215539073.3214.26.camel@localhost.localdomain> <y0mr6a4qm15.fsf@ton.toronto.redhat.com> <1215541804.3214.36.camel@localhost.localdomain> <20080708185716.GI9580@redhat.com>

Frank Ch. Eigler wrote:
>>> Also, doesn't it seem like the stap_compile{} dejagnu proc seems
>>> unnecessarily complicated [...]
>> perhaps it would be if I invented it.  In fact, I just recycled it from
>> markers.exp, the declaration.exp just needed access.

The stap_compile dejagnu proc is probably overkill for this test, but
the markers stuff tries to test code that should compile and code that
shouldn't.  (The stap_compile proc may be overkill in general, but it
tries to handle several different scenarios gracefully.)

I'm OK with moving it to a separate file.

-- 
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)

References:
- [PATCHv2 1/2] Fix semantic error: empty struct
  - From: James Bottomley
- Re: [PATCHv2 1/2] Fix semantic error: empty struct
  - From: Frank Ch. Eigler
- Re: [PATCHv2 1/2] Fix semantic error: empty struct
  - From: James Bottomley
- Re: [PATCHv2 1/2] Fix semantic error: empty struct
  - From: Frank Ch. Eigler

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]