This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
RE: [PATCH] systemtap: fix up on_each_cpu() for kernels 2.6.26+
- From: "Stone, Joshua I" <joshua dot i dot stone at intel dot com>
- To: James Bottomley <James dot Bottomley at HansenPartnership dot com>, "systemtap at sourceware dot org" <systemtap at sourceware dot org>
- Cc: linux-kernel <linux-kernel at vger dot kernel dot org>
- Date: Thu, 17 Jul 2008 16:00:39 -0700
- Subject: RE: [PATCH] systemtap: fix up on_each_cpu() for kernels 2.6.26+
- Accept-language: en-US
- Acceptlanguage: en-US
- References: <1216313476.5515.16.camel@localhost.localdomain>
James Bottomley wrote:
> In kernel 2.6.26, this patch
>
> commit 15c8b6c1aaaf1c4edd67e2f02e4d8e1bd1a51c0d
> Author: Jens Axboe <jens.axboe@oracle.com>
> Date: Fri May 9 09:39:44 2008 +0200
>
> on_each_cpu(): kill unused 'retry' parameter
>
> means that runtime/time.c is now using the wrong calling conventions.
> Fix this up and surround it by kernel versioning #ifdefs.
On a closer look, the referenced commit wasn't actually merged until
sometime between v2.6.26-git2 and -git3. The released v2.6.26 still
has 'retry' in on_each_cpu(), so we'll either have to use an autoconf
test to detect the change, or wait and key the #ifdef on 2.6.27.
Josh