This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [RFC updated PATCH 2/2] Bug Translator 3016 : Error accessing members of anonymous structs / unions
Hi -
> As per your suggestion , I've removed the clog messages and instead
> replaced them with a global (static) string to contain error messages
> in case of errors encountered in reading/decoding dwarf information.
(Actually, there remain one or two hard-coded clog references in the
patch, unless I'm misreading.)
The use of the static error_msg string is unnecessary. I advised
having an explicit try {} catch () within the search iterations, so
that each layer can just throw an exception if something is wrong.
The parent can catch exceptions and try another branch. If the search
is unsuccessful, it can throw a new (or saved/reused) exception of its
own. This should also simplify the logic.
- FChE