This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/3] PR4886: Check build-id in module_init function if able.


Thanks for the review, Frank.
Wenji is out this week, for the Chinese National holiday. He'll check it in when he gets back.


elena

Frank Ch. Eigler wrote:
Hi, Wenji -

Excellent work.  If it passes regression tests, please check it in.
It shouldn't be hard to apply it to userspace too, if it doesn't
already just work.

Some tweaks to the various messages may be helpful later, such as to
print parts of the buildid strings for eyeballing by the user, but
otherwise it looks just fine.

- FChE



--
Elena Zannoni, Oracle
Senior Engineering Manager, Tools/Languages - Linux Engineering
Blog: http://blogs.oracle.com/ezannoni
Email: elena.zannoni@oracle.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]