This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/7] kprobes: Add kprobe_insn_mutex and cleanup arch_remove_kprobe()


On Tue, 11 Nov 2008 15:56:21 -0500
Masami Hiramatsu <mhiramat@redhat.com> wrote:

> Add kprobe_insn_mutex for protecting kprobe_insn_pages hlist, and remove
> kprobe_mutex from architecture dependent code.
> 
> This allows us to call arch_remove_kprobe() (and free_insn_slot) while holding
> kprobe_mutex.
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
> ---
>  arch/arm/kernel/kprobes.c     |    2 --
>  arch/ia64/kernel/kprobes.c    |    8 +++++---
>  arch/powerpc/kernel/kprobes.c |    7 ++++---
>  arch/s390/kernel/kprobes.c    |    7 ++++---
>  arch/x86/kernel/kprobes.c     |    7 ++++---
>  include/linux/kprobes.h       |    1 -
>  kernel/kprobes.c              |   25 +++++++++++++++++++++----

For some reasons sparc64 never had this mutex.  You've checked that
sparc64 will be OK after this change?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]