This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug translator/7053] automatic global printing of statistic needs to check @count>0


------- Additional Comments From wenji dot huang at oracle dot com  2008-11-27 04:46 -------
The related code in tranlate.cxx

// PR 2142+2610: empty aggregates

3757       o->newline() << "if (unlikely (" << agg.value() << " == NULL)"

3758                    << " || " <<  agg.value() << "->count == 0) {";

3759       o->newline(1) << "c->last_error = \"empty aggregate\";";

3760       o->newline() << "goto out;";

I can't reproduce 2142 and 2610 when such code is commented. Then
sensible result will be printed in the test case. Maybe some 
improvements on global were added since that commit.

Guess we can weaken the checking of empty aggregrate.



-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=7053

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]