This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[Bug tapsets/9871] use @cast() instead of embedded-c whereever possible
- From: "mjw at redhat dot com" <sourceware-bugzilla at sourceware dot org>
- To: systemtap at sources dot redhat dot com
- Date: 5 Mar 2009 12:12:43 -0000
- Subject: [Bug tapsets/9871] use @cast() instead of embedded-c whereever possible
- References: <20090219182252.9871.fche@redhat.com>
- Reply-to: sourceware-bugzilla at sourceware dot org
------- Additional Comments From mjw at redhat dot com 2009-03-05 12:12 -------
Yes much nicer and much more readable compared to the previous versions. Thanks.
One minor stylistic request. Could you add spaces around the ? and : so that
something like:
dentry = file? @cast(file, "file", "kernel")->f_dentry: 0
will look like:
dentry = file ? @cast(file, "file", "kernel")->f_dentry : 0
that makes them a bit more readable and makes the sources a bit more consistent
(currently the sources sometimes do and sometimes don't add spaces).
--
http://sourceware.org/bugzilla/show_bug.cgi?id=9871
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.