This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[Bug runtime/9937] verify user-space build-ids
- From: "mjw at redhat dot com" <sourceware-bugzilla at sourceware dot org>
- To: systemtap at sources dot redhat dot com
- Date: 17 Mar 2009 13:22:30 -0000
- Subject: [Bug runtime/9937] verify user-space build-ids
- References: <20090310122330.9937.fche@redhat.com>
- Reply-to: sourceware-bugzilla at sourceware dot org
------- Additional Comments From mjw at redhat dot com 2009-03-17 13:22 -------
(In reply to comment #5)
> > 2. Searching the found task in _stp_modules through tgt->pathname/vm_path. Is
> > it enough?
>
> I believe this is enough, the vm_path is the complete canonical path. We do need
> to make sure to register the module names also with their full canonical names.
I made sure they are through the following commit. The path is now used in the
taskfinder vma tracker to compare against the vm_path. Maybe name could be
completely replaced by path, but for the kernel and modules name is kind of
special (we do check for the "kernel" name in a couple of places). So for now it
is just an extra field for use at runtime.
commit 30cb532a560ed152b86506b80490e99195970271
Author: Mark Wielaard <mjw@redhat.com>
Date: Tue Mar 17 13:50:33 2009 +0100
Get the canonical path of the main file for comparison at runtime.
When given directly by the user through -d or in case of the kernel
name and path might differ. path should be used for matching.
* runtime/sym.h (_stp_module): Add path field.
* runtime/task_finder.c (__stp_tf_vm_cb): Use module path to compare vm_path
* translate.cxx (dump_unwindsyms): Output canonical path.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=9937
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.