This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip 3/4 V3] tracing: kprobe-tracer plugin supports arguments
- From: Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: Ingo Molnar <mingo at elte dot hu>, Steven Rostedt <rostedt at goodmis dot org>, Frederic Weisbecker <fweisbec at gmail dot com>, systemtap-ml <systemtap at sources dot redhat dot com>, Linux Kernel Mailing List <linux-kernel at vger dot kernel dot org>, Andrew Morton <akpm at linux-foundation dot org>
- Date: Mon, 30 Mar 2009 10:28:13 +0530
- Subject: Re: [PATCH -tip 3/4 V3] tracing: kprobe-tracer plugin supports arguments
- References: <49CC08D2.30608@redhat.com>
- Reply-to: ananth at in dot ibm dot com
On Thu, Mar 26, 2009 at 06:59:30PM -0400, Masami Hiramatsu wrote:
> +/* TODO: Move these functions to arch/XXX/include/asm/debugger.h */
> +
Maybe arch/xxx/lib/<>.c too?
I know its on your list of TODOs but I'd prefer to have an
arch_fetch_func_args() or somesuch in arch specific code, to start with.
It is trivial to implement the argument extraction code on certain
architectures and such a helper would be great.
Ananth