Re: Systemtap snap:b6371390 test on kernel 2.6.30-rc3-git2

[Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>]

On Wed, Apr 29, 2009 at 10:57:01AM +0200, Mark Wielaard wrote:
> On Tue, 2009-04-28 at 12:26 +0530, Ananth N Mavinakayanahalli wrote:
> > On Mon, Apr 27, 2009 at 04:42:50PM +0200, Mark Wielaard wrote:
> > > On Mon, 2009-04-27 at 17:17 +0530, Pavan Naregundi wrote:
> > > > Results of systemtap snap:b6371390 test on kernel 2.6.30-rc3-git2
> > > > Arch: ppc64
> > > >
> > > > FAIL: LOCAL1 (0)
> > 
> > I've seen the above fail with LOCAL1 (2), which actually needs to be
> > flagged as a success. I guess the issue is with checking of rc -- down
> > in alternatives.exp:
> > 
> > - if {$rc == 1} { pass $test } else { fail "$test ($rc)" }
> > + if {$rc >= 1} { pass $test } else { fail "$test ($rc)" }
> > 
> > should fix the problem.
> 
> Yes, that seems fine. The LOCAL1 (0) failure case is as you observed
> because of the syscall wrappers issue (I am thinking about the patch you
> proposed in PR10007 and testing it locally - x86_64 only for now
> though).

Thanks Mark. I've attached an updated version just now.

Ananth