This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC PATCH tracing/kprobes 2/5] tracing/kprobes: Avoid field name confliction

From: Masami Hiramatsu <mhiramat at redhat dot com>
To: Li Zefan <lizf at cn dot fujitsu dot com>
Cc: Frederic Weisbecker <fweisbec at gmail dot com>, Steven Rostedt <rostedt at goodmis dot org>, Ingo Molnar <mingo at elte dot hu>, lkml <linux-kernel at vger dot kernel dot org>, systemtap-ml <systemtap at sources dot redhat dot com>, DLE <dle-develop at lists dot sourceforge dot net>, Thomas Gleixner <tglx at linutronix dot de>, Arnaldo Carvalho de Melo <acme at redhat dot com>, Mike Galbraith <efault at gmx dot de>, Paul Mackerras <paulus at samba dot org>, Peter Zijlstra <a dot p dot zijlstra at chello dot nl>, Christoph Hellwig <hch at infradead dot org>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Jim Keniston <jkenisto at us dot ibm dot com>, "Frank Ch. Eigler" <fche at redhat dot com>
Date: Mon, 28 Sep 2009 12:52:20 -0400
Subject: Re: [RFC PATCH tracing/kprobes 2/5] tracing/kprobes: Avoid field name confliction
References: <20090925191424.12939.91503.stgit@omoto> <20090925191505.12939.69682.stgit@omoto> <4AC01D6D.9070008@cn.fujitsu.com>

Li Zefan wrote:

+/* Reserved field names */
+#define FIELD_STRING_IP "ip"
+#define FIELD_STRING_NARGS "nargs"
+#define FIELD_STRING_RETIP "ret_ip"
+#define FIELD_STRING_FUNC "func"
+
+const char *reserved_field_names[] = {
+	"common_type",
+	"common_flags",
+	"common_preempt_count",
+	"common_pid",
+	"common_tgid",

There is a new common field "common_lock_depth"


Thanks, I'll add it.
Perhaps, I might need to have more generic check.
(check in define_field?)

Thank you!

+	FIELD_STRING_IP,
+	FIELD_STRING_NARGS,
+	FIELD_STRING_RETIP,
+	FIELD_STRING_FUNC,
+};


--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com

References:
- [RFC PATCH tracing/kprobes 0/5] tracing/kprobes, perf: perf kprobe support
  - From: Masami Hiramatsu
- [RFC PATCH tracing/kprobes 2/5] tracing/kprobes: Avoid field name confliction
  - From: Masami Hiramatsu
- Re: [RFC PATCH tracing/kprobes 2/5] tracing/kprobes: Avoid field name confliction
  - From: Li Zefan

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]