This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH v3] Scheduler Tapset based on kernel tracepoints
- From: Josh Stone <jistone at redhat dot com>
- To: Kiran <kiran at linux dot vnet dot ibm dot com>
- Cc: "Frank Ch. Eigler" <fche at redhat dot com>, systemtap at sources dot redhat dot com
- Date: Thu, 01 Oct 2009 10:58:12 -0700
- Subject: Re: [PATCH v3] Scheduler Tapset based on kernel tracepoints
- References: <1253715217.5193.115.camel@kiran-laptop> <4ABD49B7.60105@redhat.com> <1254214488.5689.114.camel@kiran-laptop> <4AC26BB2.40506@redhat.com> <1254416972.5891.4.camel@kiran-laptop>
On 10/01/2009 10:09 AM, Kiran wrote:
> Hi Josh,
>
> Thanks a lot for your comments. I am sending version 4 of the patch
> incorporating your comments.
Hi Kiran,
This looks good, just one more thing:
> + printf("%s\t\t%d\t%d\t%d:%d:%s + %d:%d:%s %s\n",
> + execname(), task_cpu(task), gettimeofday_ns(),
> + pid(), task_prio(task_current()), state_calc(task_state(task_current())),
> + task_pid(task), task_prio(task), state_calc(task_state(task)),
> + task_execname(task))
> + %)
> + printf("%-16s%5d%5d%d:%d:%s + %d:%d:%s %16s\n",
> + execname(), task_cpu(task), gettimeofday_ns(),
> + pid(), task_prio(task_current()), state_calc(task_state(task_current())),
> + task_pid(task), task_prio(task), state_calc(task_state(task)),
> + task_execname(task))
[...]
> + printf("%-16s%5d%5d%d:%d:%s ==> %d:%d:%s %16s\n",prev_task_name,
> + task_cpu(prev_task),gettimeofday_ns(),prev_pid,prev_priority,state_calc(prevtsk_state),next_pid,
> + next_priority,state_calc(nexttsk_state),next_task_name)
> + %)
> +
> + printf("%-16s%5d%5d%d:%d:%s ==> %d:%d:%s %16s\n",prev_task_name,
> + task_cpu(prev_task),gettimeofday_ns(),prev_pid,prev_priority,state_calc(prevtsk_state),next_pid,
> + next_priority,state_calc(nexttsk_state),next_task_name)
> +}
I'm confused why these printfs are now duplicated; I think only those
outside the '%)' are needed. If you agree, then I'll just remove the
inner printfs and then commit this.
Thanks,
Josh