This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH tracing/kprobes v2 1/5] tracing/kprobes: Rename special variables syntax
- From: Steven Rostedt <rostedt at goodmis dot org>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: Frederic Weisbecker <fweisbec at gmail dot com>, Ingo Molnar <mingo at elte dot hu>, lkml <linux-kernel at vger dot kernel dot org>, systemtap <systemtap at sources dot redhat dot com>, DLE <dle-develop at lists dot sourceforge dot net>, Thomas Gleixner <tglx at linutronix dot de>, Arnaldo Carvalho de Melo <acme at redhat dot com>, Mike Galbraith <efault at gmx dot de>, Paul Mackerras <paulus at samba dot org>, Peter Zijlstra <a dot p dot zijlstra at chello dot nl>, Christoph Hellwig <hch at infradead dot org>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Jim Keniston <jkenisto at us dot ibm dot com>, "Frank Ch. Eigler" <fche at redhat dot com>
- Date: Tue, 06 Oct 2009 20:15:34 -0400
- Subject: Re: [PATCH tracing/kprobes v2 1/5] tracing/kprobes: Rename special variables syntax
- References: <20091002214834.30906.86502.stgit@dhcp-100-2-132.bos.redhat.com> <20091002214842.30906.49220.stgit@dhcp-100-2-132.bos.redhat.com> <20091003015444.GE4828@nowhere> <4AC830F0.2010003@redhat.com> <4ACA25D5.10703@redhat.com> <20091005192609.GB6071@nowhere> <1254787973.13160.195.camel@gandalf.stny.rr.com> <4ACB52F6.7020106@redhat.com>
- Reply-to: rostedt at goodmis dot org
On Tue, 2009-10-06 at 10:23 -0400, Masami Hiramatsu wrote:
> Steven Rostedt wrote:
> >
>
> OK, so here are syntax ideas
>
> * current syntax
> <Ftrace>
> - $sp_var
> - %regs
> - @symbol
> <Perf>
> - local_var
>
> * $local syntax
> <Ftrace>
> - sp_var
> - %regs
> - @symbol
> <Perf>
> - $local_var
>
I'm fine with either of the above. I don't like either of the below.
-- Steve
> * non $ syntax 1
> <Ftrace>
> - %sp_var
> - %regs
> - @symbol
> <Perf>
> - local_var
>
> * non $ syntax 2
> <Ftrace>
> - %%sp_var or %@sp_var
> - %regs
> - @symbol
> <Perf>
> - local_var
>
> So, which one do you like to use? :-)
>
> Thank you,
>