This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH tracing/kprobes v2 4/5] perf: Add perf probe subcommand for kprobe-event setup helper


Peter Zijlstra wrote:
> On Mon, 2009-10-05 at 20:57 -0400, Masami Hiramatsu wrote:
>>>> +ifneq ($(shell sh -c "(echo '\#include <libdwarf/dwarf.h>'; echo '\#include <libdwarf/libdwarf.h>'; echo 'int main(void) { Dwarf_Debug dbg; Dwarf_Error err; dwarf_init(0, DW_DLC_READ, 0, 0, &dbg, &err); return (long)dbg; }') | $(CC) -x c - $(ALL_CFLAGS) -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -ldwarf -lelf -o /dev/null $(ALL_LDFLAGS) > /dev/null 2>&1 && echo y"), y)
>>>> +    msg := $(warning No libdwarf.h found, disables probe subcommand. Please install libdwarf-dev/libdwarf-devel);
>>>
>>> Wow! And I thought my macros were ugly ;-)
>>
>> :-)
>> Maybe, would I better make a separate c file to check this?
>> Like "autoconf-checkdwarf.c".
> 
> I'm the one who started this trend.. Maybe putting all those tests in a
> static .c file makes sense now, put them in a tests/ or checks/
> directory though, so it doesn't litter the regular files.
> 
> Then again,.. the actual .c file is only half that line, so it doesn't
> really clean up that much.

Yeah, ok, then I'll leave this part in this series.
It's better to be done in another series.

Thank you,

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]