This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2] PR5434: Fix syscall.nfsservctl.

From: Przemysław Pawełczyk <przemyslaw at pawelczyk dot it>
To: systemtap at sourceware dot org
Date: Tue, 13 Oct 2009 14:42:56 +0200
Subject: Re: [PATCH v2] PR5434: Fix syscall.nfsservctl.
References: <1255172147.582433.8754@debian> <1255398417.266449.10034@debian>

On Tue, Oct 13, 2009 at 03:23, Przemyslaw Pawelczyk
<przemyslaw@pawelczyk.it> wrote:
> Use proper $vars according to CONFIG_NFSD and CONFIG_COMPAT in
> syscall.nfsservctl and mask it out along with return probe if
> CONFIG_NFSD != "[ym]" && CONFIG_COMPAT != "y".

I had a bad day yesterday. Really. Good that I don't have rights to
the repository, because I would give a new meaning to saying commit an
error...

> +%( CONFIG_NFSD == "[ym]" || CONFIG_COMPAT == "y" %?

> +%( CONFIG_NFSD == "[ym]" %?

Above lines were wrong, but now thankfully there are correct thanks to
Josh for spotting the typo in CONFIG_-related code and Frank for
fixing it (commit e61d83ef).

-- 
Przemysław Pawełczyk

References:
- [PATCH 2/2] PR5434: Use proper $vars according to CONFIG_NFSD in syscall.nfsservctl.
  - From: Przemyslaw Pawelczyk
- [PATCH v2] PR5434: Fix syscall.nfsservctl.
  - From: Przemyslaw Pawelczyk

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]