This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] PR10257: Add support for sprint[ln](@hist_*).
Hi Josh,
On Tue, 2009-10-13 at 19:24 -0700, Josh Stone wrote:
> I committed this patch, and then also did some refactoring of my own.
> Let me know if I broke it... :)
I am afraid something in your last cleanup broke some of the vars.exp
and uprobes.exp tests:
FAIL: uprobes -p5 (0)
FAIL: vars
FAIL: vars parms/locals
d5e178c1d6eb0e7c1a317b925687050aa1cb6c1b is first bad commit
commit d5e178c1d6eb0e7c1a317b925687050aa1cb6c1b
Author: Josh Stone <jistone@redhat.com>
Date: Tue Oct 13 16:57:38 2009 -0700
Consolidate print_format creation
We almost had a factory in print_format::parse_print, so let's take
that
the rest of the way. This way we don't have so much duplication in
initializing the print flags.
* staptree.cxx (print_format::parse_print): Replaced with...
(print_format::create): New factory to parse and create
print_formats.
* elaborate.cxx (add_global_var_display): Use this factory.
* parse.cxx (parser::parse_symbol): Ditto.
* tapset-mark.cxx
(mark_var_expanding_visitor::visit_target_symbol_context): Ditto.
* tapset-utrace.cxx
(utrace_var_expanding_visitor::visit_target_symbol_arg): Ditto.
* tapsets.cxx
(dwarf_var_expanding_visitor::visit_target_symbol_context): Ditto.
(tracepoint_var_expanding_visitor::visit_target_symbol_context)
Ditto.