This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] tty: improving the ttyspy example

From: Breno Leitao <leitao at linux dot vnet dot ibm dot com>
To: David Smith <dsmith at redhat dot com>
Cc: systemtap at sources dot redhat dot com
Date: Wed, 21 Oct 2009 11:31:58 -0200
Subject: Re: [PATCH] tty: improving the ttyspy example
References: <1256062127-13868-1-git-send-email-leitao@linux.vnet.ibm.com> <1256062127-13868-2-git-send-email-leitao@linux.vnet.ibm.com> <1256062127-13868-3-git-send-email-leitao@linux.vnet.ibm.com> <4ADE2686.30905@redhat.com>

David Smith wrote:
> In general, the tapset and testcase look fine.  There are two questions
> I have that I've asked about below.
> 
> But, I'm not sure these changes improves the ttyspy.stp example.  I've
> never actually run it, but I believe your changes will display data that
> the existing probes have already printed (and disrupt the output
> formatting).
Yes. That is true. What is your suggestion here ?

Follow-Ups:
- Re: [PATCH] tty: improving the ttyspy example
  - From: David Smith

References:
- [PATCH] A new tapset that adds support for tty and serial devices
  - From: leitao
- [PATCH] A new testcase for tty tapset
  - From: leitao
- [PATCH] tty: improving the ttyspy example
  - From: leitao
- Re: [PATCH] tty: improving the ttyspy example
  - From: David Smith

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]