This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
RE: [RFC PATCH] Fix segmentation fault of listing kprocess.create
- From: "Wenji Huang" <wenji dot huang at oracle dot com>
- To: "systemtap at sourceware dot org" <systemtap at sourceware dot org>
- Date: Thu, 5 Nov 2009 15:38:51 +0800
- Subject: RE: [RFC PATCH] Fix segmentation fault of listing kprocess.create
- Reply-to: "wenji dot huang at oracle dot com" <wenji dot huang at oracle dot com>
Hi,
Sorry for a little annoying thread. ^-^
> Please ignore the previous patch, the root cause is the
> following section
> tapsets.cxx: dwarf_derived_probe::saveargs
>
> /* trick from visit_target_symbol_context */
> target_symbol *tsym = new target_symbol;
> token *t = new token;
> tsym->tok = t;
> tsym->base_name = "$";
> tsym->base_name += arg_name;
>
> The empty token is created, I will fix it soon.
> Also any suggestion is welcome!
>
Take a deep look. Seems we will try to access the variables in
return probe. It's fully supported or not? Guess not.
If not, the function should return early once has_return is true.
If yes, we will hypothesize accessing the argument. And the
source_loc of t has to be q.base_loc since no real one.
Regards,
Wenji