Re: Tapset for probing IRQs, workqueues, etc

[Mark Wielaard <mjw at redhat dot com>]

Hi Prerna,

On Mon, 2009-11-09 at 11:43 +0530, Prerna Saxena wrote:
> On 10/30/2009 04:44 AM, Josh Stone wrote:
> > On 10/29/2009 08:55 AM, Prerna Saxena wrote:
> >> I have not included the flags string on purpose for this probe point,
> >> cos I think that one might need to look up the flags in specific
> >> debugging scenarios only. It would not be required in most commonly used
> >> cases, such as the attached example. However, I have documented the
> >> function both inline in the tapset documentation and also in the man
> >> pages, so that a script developer wanting to display a formatted string
> >> can call the function when needed.
> >
> > It wouldn't hurt to have the tapset provide it as something like
> > flags_str.  That makes it more obvious for the user, and our optimizer
> > should remove it automatically if it's not used.
> >
> Thanks!
> Fixed in commit a476086d1ef0448c86e466f5955f78d282b473fd for new IRQ tapset.

That commit calls irqflag_str() in the tapset/irq.stp, but didn't add
the function itself. I assume you have it locally in aux_syscalls.stp.
Could you commit that also?

Thanks,

Mark