This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[PATCH 1/4] powerpc: Fix thinko in _stp_arg()
- From: Anton Vorontsov <avorontsov at ru dot mvista dot com>
- To: systemtap at sourceware dot org
- Cc: Jim Keniston <jkenisto at us dot ibm dot com>, ananth at in dot ibm dot com, linuxppc-dev at ozlabs dot org
- Date: Fri, 4 Dec 2009 02:31:51 +0300
- Subject: [PATCH 1/4] powerpc: Fix thinko in _stp_arg()
- References: <20091203233059.GA28186@oksana.dev.rtsoft.ru>
_stp_arg() has an almost unnoticeable thinko in the argnum handling,
which causes it to always return u_register("r10"):
'else (argnum == 8)' should actually be 'else if (argnum == 8)'.
Though, since we check for 'if (argnum < 1 || argnum > 8)' at the
beginning of _stp_arg(), let's make it just 'else'.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
tapset/powerpc/registers.stp | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tapset/powerpc/registers.stp b/tapset/powerpc/registers.stp
index c8713e5..7f66d36 100644
--- a/tapset/powerpc/registers.stp
+++ b/tapset/powerpc/registers.stp
@@ -146,7 +146,7 @@ function _stp_arg:long (argnum:long, sign_extend:long, truncate:long) {
val = u_register("r8")
else if (argnum == 7)
val = u_register("r9")
- else (argnum == 8)
+ else
val = u_register("r10")
if (truncate) {
--
1.6.3.3