This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip 2/4] perf probe: Fix to use symtab only if no debuginfo
- From: Arnaldo Carvalho de Melo <acme at redhat dot com>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: Ingo Molnar <mingo at elte dot hu>, lkml <linux-kernel at vger dot kernel dot org>, Paul Mackerras <paulus at samba dot org>, Peter Zijlstra <peterz at infradead dot org>, Mike Galbraith <efault at gmx dot de>, Frederic Weisbecker <fweisbec at gmail dot com>, systemtap <systemtap at sources dot redhat dot com>, DLE <dle-develop at lists dot sourceforge dot net>
- Date: Mon, 26 Apr 2010 09:48:15 -0300
- Subject: Re: [PATCH -tip 2/4] perf probe: Fix to use symtab only if no debuginfo
- References: <20100421195616.24664.89980.stgit@localhost6.localdomain6> <20100421195624.24664.46214.stgit@localhost6.localdomain6>
Em Wed, Apr 21, 2010 at 03:56:24PM -0400, Masami Hiramatsu escreveu:
> Fix perf probe to use symtab only if there is no debuginfo,
> because debuginfo has more precise information than symtab.
"more precise"? Wouldn't it be "more expressive", i.e. with more
information (parameter list with types, return type, location of
parameters, etc), because what is common to both have the same value,
i.e. the function address and size.
> If we can't find a function in debuginfo, we never find it
> in symtab.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
> Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Mike Galbraith <efault@gmx.de>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> ---
>
> tools/perf/util/probe-event.c | 17 +++++++++--------
> 1 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 4fb4803..5d3baec 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -180,15 +180,16 @@ static int try_to_find_kprobe_trace_events(struct perf_probe_event *pev,
> return -ENOENT;
> }
> /* Error path : ntevs < 0 */
> - if (need_dwarf) {
> - if (ntevs == -EBADF)
> - pr_warning("No dwarf info found in the vmlinux - "
> - "please rebuild with CONFIG_DEBUG_INFO=y.\n");
> - return ntevs;
> + pr_debug("An error occurred in debuginfo analysis (%d).\n", ntevs);
> + if (ntevs == -EBADF) {
> + pr_warning("Warning: No dwarf info found in the vmlinux - "
> + "please rebuild kernel with CONFIG_DEBUG_INFO=y.\n");
> + if (!need_dwarf) {
> + pr_debug("Trying to use symbols.\nn");
> + return 0;
> + }
> }
> - pr_debug("An error occurred in debuginfo analysis."
> - " Try to use symbols.\n");
> - return 0;
> + return ntevs;
> }
>
> #define LINEBUF_SIZE 256
>
>
> --
> Masami Hiramatsu
> e-mail: mhiramat@redhat.com