This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/1] Add environment variable fetching for current process


>From Josh Stone <jistone@redhat.com>, Wed, Jun 02, 2010 at 07:19:39PM -0700:
> 
> This looks good, but I made a small tweak:
> 
> > +          if (len > 0)
> > +            env_value = tokenize("", "=");
> 
> If the actual value happens to have "=" in it, we don't want to truncate
> it.  Using a "" delimiter instead lets us grab the entire remaining string.

That makes sense--thanks! I'd misunderstood how the tokenize function
works.

-lars

--
lars r. damerow :: button pusher :: pixar animation studios


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]