This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ppc nd_syscall broken (was Re: manual SyS_foo management is unnecessary?)


On 06/15/2010 01:07 PM, David Smith wrote:
> The error is in the 'argnum == 8' case - there is a missing 'if'.  That
> line should be:
> 
> 	else if (argnum == 8)
> 		val = u_register("r10")
> 
> Since there was no "if", systemtap grabbed the register you asked for,
> then always grabbed the value of r10.  So, that garbage we saw was
> really the value of r10.

I haven't actually run the code, but it looks like the s390x version of
registers.stp suffers from the same missing "if" problem...

-- 
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]