This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] Factor out d_path printing for any dentry.


On 10/20/2010 10:46 AM, Erick Tryzelaar wrote:
> ---
>  tapset/dentry.stp |   38 ++++++++++++++++++++++++++++----------
>  1 files changed, 28 insertions(+), 10 deletions(-)
> 

Thanks, I've pushed both of these.

When adding a new function, please consider what testing can be done for
it.  We don't have much testing in place for the dentry functions, but I
did add your new function to testsuite/buildok/dentry-embedded.stp
(Even though it was indirectly there via d_path(), it's good to
explicitly test everything we can.)

Josh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]