This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [RFC] [PATCH 2.6.37-rc5-tip 8/20] 8: uprobes: mmap and fork hooks.
- From: Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>
- To: Steven Rostedt <rostedt at goodmis dot org>
- Cc: Peter Zijlstra <peterz at infradead dot org>, Ingo Molnar <mingo at elte dot hu>, Arnaldo Carvalho de Melo <acme at infradead dot org>, Linus Torvalds <torvalds at linux-foundation dot org>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Christoph Hellwig <hch at infradead dot org>, Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>, Oleg Nesterov <oleg at redhat dot com>, LKML <linux-kernel at vger dot kernel dot org>, SystemTap <systemtap at sources dot redhat dot com>, Jim Keniston <jkenisto at linux dot vnet dot ibm dot com>, Frederic Weisbecker <fweisbec at gmail dot com>, Andi Kleen <andi at firstfloor dot org>, Andrew Morton <akpm at linux-foundation dot org>, "Paul E. McKenney" <paulmck at linux dot vnet dot ibm dot com>
- Date: Wed, 26 Jan 2011 14:36:43 +0530
- Subject: Re: [RFC] [PATCH 2.6.37-rc5-tip 8/20] 8: uprobes: mmap and fork hooks.
- References: <20101216095714.23751.52601.sendpatchset@localhost6.localdomain6> <20101216095848.23751.73144.sendpatchset@localhost6.localdomain6> <1295957741.28776.719.camel@laptop> <1295985926.10144.61.camel@gandalf.stny.rr.com>
- Reply-to: Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>
* Steven Rostedt <rostedt@goodmis.org> [2011-01-25 15:05:26]:
> On Tue, 2011-01-25 at 13:15 +0100, Peter Zijlstra wrote:
> > On Thu, 2010-12-16 at 15:28 +0530, Srikar Dronamraju wrote:
>
> > > +static void search_within_subtree(struct rb_node *n, struct inode *inode,
> > > + struct list_head *tmp_list)
> > > +{
> > > + struct rb_node *p;
> > > +
> > > + if (p)
> > > + __search_within_subtree(p, inode, tmp_list);
> > > +
> > > + p = n->rb_right;
> > > + if (p)
> > > + __search_within_subtree(p, inode, tmp_list);
> > > +}
> >
> > Whee recursion FTW!, you just blew your kernel stack :-)
> >
> > Since you sort inode first, offset second, I think you can simply look
> > for the first matching inode entry and simply rb_next() until you don't
> > match.
>
> Not to mention that p is uninitialized. Did this code ever work?
I think the original patch that I sent had p initialized. I think it got
dropped off by Peter when he replied. Please do confirm.
--
Thanks and Regards
Srikar