This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [RFC] [PATCH 2.6.37-rc5-tip 4/20] 4: uprobes: Adding and remove a uprobe in a rb tree.
- From: Peter Zijlstra <peterz at infradead dot org>
- To: Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>
- Cc: Ingo Molnar <mingo at elte dot hu>, Steven Rostedt <rostedt at goodmis dot org>, Arnaldo Carvalho de Melo <acme at infradead dot org>, Linus Torvalds <torvalds at linux-foundation dot org>, Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>, Christoph Hellwig <hch at infradead dot org>, Andi Kleen <andi at firstfloor dot org>, Oleg Nesterov <oleg at redhat dot com>, LKML <linux-kernel at vger dot kernel dot org>, SystemTap <systemtap at sources dot redhat dot com>, Jim Keniston <jkenisto at linux dot vnet dot ibm dot com>, Frederic Weisbecker <fweisbec at gmail dot com>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Andrew Morton <akpm at linux-foundation dot org>, "Paul E. McKenney" <paulmck at linux dot vnet dot ibm dot com>
- Date: Wed, 26 Jan 2011 16:33:14 +0100
- Subject: Re: [RFC] [PATCH 2.6.37-rc5-tip 4/20] 4: uprobes: Adding and remove a uprobe in a rb tree.
- References: <20101216095714.23751.52601.sendpatchset@localhost6.localdomain6> <20101216095803.23751.41491.sendpatchset@localhost6.localdomain6> <1295963773.28776.1054.camel@laptop> <20110126084522.GF19725@linux.vnet.ibm.com> <1296036847.28776.1142.camel@laptop> <20110126151842.GM19725@linux.vnet.ibm.com>
On Wed, 2011-01-26 at 20:48 +0530, Srikar Dronamraju wrote:
> * Peter Zijlstra <peterz@infradead.org> [2011-01-26 11:14:07]:
>
> > On Wed, 2011-01-26 at 14:15 +0530, Srikar Dronamraju wrote:
> > >
> > >
> > > Okay, Will do, but Is there a reason for moving the fvalue out of the
> > > uprobe_consumer? Except for reducing the size of the structure, I am
> > > unable to see advantage.
> >
> > That's about it, and its the normal way to do such things in kernel
> > space.
>
> But the disadvantage would be we wont be able to share the filter
> functions. Currently i had one patch that implemented the common
> filter functions that tracers could reuse.
But you could still do that, just make then use something like:
struct uprobe_simple_consumer {
struct uprobe_consumer consumer;
unsigned long value;
};