This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[Bug tapsets/12470] Fix _wait4_opt_str
- From: "dsmith at redhat dot com" <sourceware-bugzilla at sourceware dot org>
- To: systemtap at sources dot redhat dot com
- Date: Wed, 9 Feb 2011 16:42:14 +0000
- Subject: [Bug tapsets/12470] Fix _wait4_opt_str
- Auto-submitted: auto-generated
- References: <bug-12470-1110@http.sourceware.org/bugzilla/>
http://sourceware.org/bugzilla/show_bug.cgi?id=12470
David Smith <dsmith at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dsmith at redhat dot com
--- Comment #2 from David Smith <dsmith at redhat dot com> 2011-02-09 16:42:03 UTC ---
(In reply to comment #1)
> Created attachment 5231 [details]
> Fix #2.
The patch looks reasonable to me in general. However, we don't handle unknown
option values like this anywhere else (that I know of). If we decide this is a
good idea, we should probably file a bug against the rest of the option
decoding functions.
One more thing. The patch might be improved by using the functionality
implemented for bug #11566, which would change code like this:
if (f & 1)
{
f&=~1
retval=retval."|WNOHANG"
}
into something like this (actually using the #defines):
if (f & %{ WNOHANG %})
{
f&=%{ ~WNOHANG %}
retval=retval."|WNOHANG"
}
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.