This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH v3 2.6.39-rc1-tip 22/26] 22: perf: rename target_module to target
- From: Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>
- To: Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>
- Cc: Peter Zijlstra <peterz at infradead dot org>, Ingo Molnar <mingo at elte dot hu>, Steven Rostedt <rostedt at goodmis dot org>, Linux-mm <linux-mm at kvack dot org>, Arnaldo Carvalho de Melo <acme at infradead dot org>, Linus Torvalds <torvalds at linux-foundation dot org>, Andi Kleen <andi at firstfloor dot org>, Christoph Hellwig <hch at infradead dot org>, Jonathan Corbet <corbet at lwn dot net>, Thomas Gleixner <tglx at linutronix dot de>, Oleg Nesterov <oleg at redhat dot com>, Andrew Morton <akpm at linux-foundation dot org>, SystemTap <systemtap at sources dot redhat dot com>, Jim Keniston <jkenisto at linux dot vnet dot ibm dot com>, Roland McGrath <roland at hack dot frob dot com>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, LKML <linux-kernel at vger dot kernel dot org>, "2nddept-manager at sdl dot hitachi dot co dot jp" <2nddept-manager at sdl dot hitachi dot co dot jp>
- Date: Thu, 7 Apr 2011 05:16:24 +0530
- Subject: Re: [PATCH v3 2.6.39-rc1-tip 22/26] 22: perf: rename target_module to target
- References: <20110401143223.15455.19844.sendpatchset@localhost6.localdomain6> <20110401143657.15455.4701.sendpatchset@localhost6.localdomain6> <4D99980E.5080807@hitachi.com>
- Reply-to: Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>
> >
> > -int show_available_funcs(const char *module, struct strfilter *_filter)
> > +int show_available_funcs(const char *elfobject, struct strfilter *_filter)
> > {
> > struct map *map;
> > int ret;
> > @@ -1990,9 +1990,9 @@ int show_available_funcs(const char *module, struct strfilter *_filter)
> > if (ret < 0)
> > return ret;
> >
> > - map = kernel_get_module_map(module);
> > + map = kernel_get_module_map(elfobject);
> > if (!map) {
> > - pr_err("Failed to find %s map.\n", (module) ? : "kernel");
> > + pr_err("Failed to find %s map.\n", (elfobject) ? : "kernel");
>
> Hmm, these changes(module -> elfobject) are put back by the next patch.
> Could you check your patch stack?
>
In the next patch, we move "map =
kernel_get_module_map(module/elfobject)" to a new function
available_kernel_funcs(). For example: Even after the next patch,
show_available_funcs() still takes elfobject and not module. If you want
to avoid this, then we would have to either introduce the
available_kernel_funcs() in this patch Or we could merge this and the
next patch. Both those solutions dont look clean to me.
--
Thanks and Regards
Srikar