This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Puzzling output of stp script

From: Mark Wielaard <mark at klomp dot org>
To: Adrien Kunysz <adrien at kunysz dot be>
Cc: Josh Stone <jistone at redhat dot com>, contemplating zombie <contemplatingzombie at gmail dot com>, systemtap at sourceware dot org
Date: Sun, 25 Dec 2011 21:20:26 +0100
Subject: Re: Puzzling output of stp script
References: <CAO_gTC6yXVN-6a-aj6YFy4Z_7wGaMRzbHTWWWdQOyWgD=g0rOQ@mail.gmail.com> <CAO_gTC5M4q3-CS_xuY8C2BQ-4teLUer6DSEZpRdKp8_PJ-ep_w@mail.gmail.com> <4EF6BAEB.7000006@redhat.com> <20111225110952.GD17069@chouffe>

On Sun, Dec 25, 2011 at 11:09:52AM +0000, Adrien Kunysz wrote:
> And that particular example was already fixed a while ago btw:
> http://sourceware.org/git/gitweb.cgi?p=systemtap.git;a=commitdiff;h=396afcee5ada2d207b7a6691d4b7ce473e7b2a65

But it was still used in at least two places, the tutorial and beginner's
guide, without the .call modifier. Fixed those too and added Josh's
suggestion as an exercise:

commit 2e96e9163d84fe9772def0318216a6d6da1332a2
Author: Mark Wielaard <mjw@redhat.com>
Date:   Sun Dec 25 20:56:53 2011 +0100

  Use function.call and function.return in all thread_indent() examples.

  If the .call modifier isn't used the function probes will match both .call
  and .inline, but .return doesn't match any inlined functions leading to
  unbalanced thread_indent output.

Cheers,

Mark

References:
- Puzzling output of stp script
  - From: contemplating zombie
- Re: Puzzling output of stp script
  - From: Josh Stone
- Re: Puzzling output of stp script
  - From: Adrien Kunysz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]