This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] add dbug_task_vma debug macro
- From: Mark Wielaard <mjw at redhat dot com>
- To: Negreanu Marius Adrian <adrian dot m dot negreanu at intel dot com>
- Cc: systemtap at sourceware dot org
- Date: Mon, 14 May 2012 12:15:53 +0200
- Subject: Re: [PATCH] add dbug_task_vma debug macro
- References: <1336833118-19175-1-git-send-email-adrian.m.negreanu@intel.com>
On Sat, 2012-05-12 at 17:31 +0300, Negreanu Marius Adrian wrote:
> replace DEBUG_TASK_FINDER_VMA
> with a dbug_unwind-like macro: dbug_task_vma
> ---
> runtime/debug.h | 10 ++++++++++
> runtime/task_finder.c | 8 ++------
> runtime/task_finder2.c | 8 ++------
> runtime/uprobes-common.c | 20 +++++---------------
> runtime/vma.c | 40 ++++++++++------------------------------
> 5 files changed, 29 insertions(+), 57 deletions(-)
Thanks, that is much nicer than the scattered #if
defined(DEBUG_TASK_FINDER_VMA) throughout the source. Pushed.
There is also the plain DEBUG_TASK_FINDER (all non-vma stuff) that could
be done in the same way.
Thanks,
Mark