This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Enhanced Garbage Collection Probe Points



----- Original Message -----
> From: "Mark Wielaard" <mark@klomp.org>
> To: "Jon VanAlten" <jvanalte@redhat.com>
> Cc: "Andrew Hughes" <gnu.andrew@redhat.com>, systemtap@sourceware.org, distro-pkg-dev@openjdk.java.net, "Lukas Berk"
> <lberk@redhat.com>
> Sent: Thursday, November 1, 2012 3:05:45 PM
> Subject: Re: [RFC] Enhanced Garbage Collection Probe Points
> 
> On Thu, 2012-11-01 at 14:32 -0400, Jon VanAlten wrote:
> > I would also prefer the 7 stuff to go to the forest, but...
> > 
> > > From: "Mark Wielaard" <mark@klomp.org>
> > 
> > <SNIP>
> > > 
> > > Adding patches directly to the tree is fine with me.
> > > My only hesitation was my own confusion since the default
> > > configure/make setup doesn't pick up a patched forest.
> > > You don't have that issue with patches, which are directly
> > > applied. If we are going for a complete forest setup it
> > > might make sense to also add the tapsets and testsuite
> > > directly there.
> > > 
> > > I'll try and figure it all out again and also port the existing
> > > patches to the forest. Hints and tips appreciated.
> > 
> > So about this patch and 7, I'm getting mixed messages here.
> 
> What is the mixed message?

Just the difference between Andrew's message (which I will
summarize as "forest not tree except where there is no forest")
and yours ("tree is OK, forest is also probably OK but so far I
don't 'get' it").

> I am fine with adding patches directly to
> the
> forest and even adding the other stuff like the tapsets and the
> staptests there. I just don't know the workflow when I would work
> against the forest directly and not just have patches in the tree.
> And I
> just haven't found the time to create a new workflow. I am sure it is
> just a different ./configure flag, just haven't figured out which
> one.
> So, how do people work against the forest directly? What configure
> flags
> do they use? What does your edit/build/test/commit/pull cycle look
> like?

I admit to forest-ignorance as well, and would appreciate any and all
suggestions here.  Perhaps someone has a pointer to some changesets
in both tree and forest where some conditionally-applied patch has
undergone a similar move?

cheers,
jon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]