This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: loc2c-test with dwarf_entry_breakpoints


On Thu, 2013-02-21 at 17:52 -0500, Lukas Berk wrote:
> Pending the former patch I've attached loc2c-test.patch.1 (which
> builds on the first patch), implementing @functionname to use the
> first breakpoint address and exiting with a message if there are
> multiple breakpoints.

The loc2c-test.patch.1 doesn't seem to implement the @functionname
variant (as in select the entry-breakpoint address), but the plain
functionname variant works as expected. nice.

Only a few small nitpicks:
- The --help text should be changed to show you can use either
  ADDRESS or FUNCTIONNAME now.
- Please keep lines < 80 chars if possible.
- The '\t' in the output when listing all functions with their entry
  and breakpoint addresses make things very, very wide.
  Could you consider just using spaces?

Thanks,

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]