This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hey, [...] > > One more little nitpick, the "header" should show the same spacing. > Something like: > > printf ("Function " > "Address Debug Entry Address(s)\n"); > OK, I used whitespace formatting to keep it a bit more manageable, but the header now matches in terms of spacing. > OK, and another, matchdebug should be bool, not int. Fixed. > > + a.funcname = argv[argi]; > > + char* at = strchr (a.funcname, '@'); > > + /* We need to check and adjust for a possible '@' character */ > > + if(at != NULL) > > + { > > + *at++ = '\0'; > > + a.funcname = at; > > This would be simpler as follows: > > a.funcname = argv[argi]; > /* We need to check and adjust for a possible '@' character */ > if(a.funcname[0] == '@') > { > a.funcname++; Ah thanks, changed it. Final patch attached. Cheers, Lukas
Attachment:
loc2c-test.patch
Description: Text document
Attachment:
pgp00000.pgp
Description: PGP signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |