This is the mail archive of the xconq7@sources.redhat.com mailing list for the Xconq project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: code in adjust_tooling_crossover?


> As for the "vanishes on" fix I was working on, when I work on
> plan_colonize, I can't seem to access anything within unit2 without
> causing a segfault.  I tried adding the following line of code after it
> decides if the cell is "good":
> 
> if (!ut_vanishes_on(unit2->type, terrain_at(x, y))) {

Uh, I think you are looking for plan->maingoal->args[0] rather than
unit2->type.

Cleaning up the variable names in this function would be helpful.
unit2 is only used in one small place (and so I'd move it there).
Likewise for u2 (and unit2 and u2 don't have anything to do with each
other :-().


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]