Re: emblem drawing glitches on linux

[Hans Ronne <hronne at telia dot com>]

>Unit names were already off so I tried with unit names on.
>There is a small change but the glitches are still there.  The
>difference is that the glitch emblems only appear in the W and
>NW cells, instead of W, NW, NE, E, and SE cells as they did in
>my long turn-by-turn description of the problem.

OK. That's because the name erasing code in part erases your glitch.

>> And what happens if you start the game with see-all? Do they
>> disappear then?
>
>Yes! The problem goes away completely.
>
>>
>> 2. There weer also some changes to draw_current which draws
>> the current unit. What happens if you back out of these
>> changes (if possible) so that the unit view-specific code is
>> bypassed?
>
>No glitch emblems!  This looks promising.  Let me know if there
>is anything else you would like me to try.

I'm not 100% sure whay the problem is yet, but perhaps you could try this
patch in draw_current:

	if (vp->show_all) {
	    x_xform_unit_self(mapw, unit, &sx, &sy, &sw, &sh);
	} else if (uview) {
	    rslt = x_xform_unit_self_view(mapw, uview, &sx, &sy, &sw, &sh);
	    /* This may be called while there is no view object for
	       the current unit, such as while updating the display
	       when the unit moves and is "between" cells. */
	    if (!rslt)
	      return;
+	} else {
+	    return;
	}

Hans