This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 5/7] RISC-V GAS Port
- From: Palmer Dabbelt <palmer at dabbelt dot com>
- To: nickc at redhat dot com
- Cc: Andrew Waterman <andrew at sifive dot com>
- Cc: binutils at sourceware dot org
- Date: Tue, 01 Nov 2016 11:16:24 -0700 (PDT)
- Subject: Re: [PATCH 5/7] RISC-V GAS Port
- Authentication-results: sourceware.org; auth=none
On Tue, 01 Nov 2016 05:46:02 PDT (-0700), nickc@redhat.com wrote:
> Hi Palmer,
>
> Just noticed this:
>
>> diff --git a/gas/config/tc-riscv.c b/gas/config/tc-riscv.c
> [...]
>> +/* Pseudo-op table. */
>> +static const pseudo_typeS riscv_pseudo_table[] =
>> + {"p2align", s_align, 0},
>
> This breaks one of the gas testsuite's tests (gas/testsuite/gas/all/align.s)
> because it does not support the third argument to the normal
> .p2align pseudo-op. It also means that .p2align pseudo-op does
> not behave as documented when the target is the riscv.
>
> Please could you consider extending your s_align() function to
> handle the extra argument.
I filed an issue so this doesn't get lost. I don't see any reason why we won't
just fix it, but I'll have to look.
https://github.com/riscv/riscv-binutils-gdb/issues/28
Thanks!