This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH v2][gold] Implement --build-id=uuid on MinGW/MSYS2.
- From: Igor Kudrin <ikudrin at accesssoftek dot com>
- To: Cary Coutant <ccoutant at gmail dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Wed, 9 Nov 2016 13:15:34 +0000
- Subject: Re: [PATCH v2][gold] Implement --build-id=uuid on MinGW/MSYS2.
- Authentication-results: sourceware.org; auth=none
- References: <1473243648161.89192@accesssoftek.com>,<CAJimCsHvKePNozhT3sT0DZ=8XpWF0tYGKqK5Aj8o6xK++aWPmQ@mail.gmail.com>,<1477029609926.33115@accesssoftek.com>
Ping.
________________________________________
From: binutils-owner@sourceware.org <binutils-owner@sourceware.org> on behalf of Igor Kudrin <ikudrin@accesssoftek.com>
Sent: Friday, October 21, 2016 11:58 AM
To: Cary Coutant
Cc: binutils@sourceware.org
Subject: [PATCH v2][gold] Implement --build-id=uuid on MinGW/MSYS2.
Hi Cary,
Thank you for the comments. In this version, I've replaced C-style cast
to reinterpret_cast. Hope it's OK now.
Best regards,
Igor Kudrin
---
gold/ChangeLog
* layout.cc: Changes for MinGW32:
Include windows.h and rpcdce.h.
(Layout::create_build_id): Generate uuid using UuidCreate().
________________________________________
From: Cary Coutant <ccoutant@gmail.com>
Sent: Friday, October 21, 2016 2:19 AM
To: Igor Kudrin
Cc: binutils@sourceware.org
Subject: Re: [PATCH][gold] Implement --build-id=uuid on MinGW/MSYS2.
> gold/ChangeLog
>
> * layout.cc: Changes for MinGW32:
> Include windows.h and rpcdce.h.
> (Layout::create_build_id): Use UuidCreate() to generate uuid.
+ UuidCreateFn uuid_create =
+ (UuidCreateFn)GetProcAddress(rpc_library, "UuidCreate");
Please use a C++ style case here. With that change, the patch looks good.
-cary