This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][AArch64] Add ARMv8.3 FCMLA and FCADD instructions
- From: Nick Clifton <nickc at redhat dot com>
- To: Szabolcs Nagy <szabolcs dot nagy at arm dot com>, Binutils <binutils at sourceware dot org>
- Cc: nd at arm dot com
- Date: Thu, 10 Nov 2016 14:46:14 +0000
- Subject: Re: [PATCH][AArch64] Add ARMv8.3 FCMLA and FCADD instructions
- Authentication-results: sourceware.org; auth=none
- References: <58207461.9080006@arm.com>
Hi Szabolcs,
> gas/
> 2016-11-07 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> * config/tc-aarch64.c (parse_operands): Handle AARCH64_OPND_IMM_ROT*.
>
> include/
> 2016-11-07 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> * opcode/aarch64.h (enum aarch64_opnd): Add AARCH64_OPND_IMM_ROT1,
> AARCH64_OPND_IMM_ROT2, AARCH64_OPND_IMM_ROT3.
> (enum aarch64_op): Add OP_FCMLA_ELEM.
>
> opcodes/
> 2016-11-07 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> * aarch64-tbl.h (QL_V3SAMEHSD_ROT, QL_ELEMENT_ROT): Define.
> (aarch64_feature_simd_v8_3, SIMD_V8_3): Define.
> (aarch64_opcode_table): Add fcmla and fcadd.
> (AARCH64_OPERANDS): Add IMM_ROT{1,2,3}.
> * aarch64-asm.h (aarch64_ins_imm_rotate): Declare.
> * aarch64-asm.c (aarch64_ins_imm_rotate): Define.
> * aarch64-dis.h (aarch64_ext_imm_rotate): Declare.
> * aarch64-dis.c (aarch64_ext_imm_rotate): Define.
> * aarch64-opc.h (enum aarch64_field_kind): Add FLD_rotate{1,2,3}.
> * aarch64-opc.c (fields): Add FLD_rotate{1,2,3}.
> (operand_general_constraint_met_p): Rotate and index range check.
> (aarch64_print_operand): Handle rotate operand.
> * aarch64-asm-2.c: Regenerate.
> * aarch64-dis-2.c: Likewise.
> * aarch64-opc-2.c: Likewise.
>
> gas/testsuite/
> 2016-11-07 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> * gas/aarch64/advsimd-armv8_3.d: New.
> * gas/aarch64/advsimd-armv8_3.s: New.
> * gas/aarch64/illegal-fcmla.s: New.
> * gas/aarch64/illegal-fcmla.l: New.
> * gas/aarch64/illegal-fcmla.d: New.
Approved - please apply.
Cheers
Nick