RE: enlightenment & Eterm

[Suhaib Siddiqi <ssiddiqi at inspirepharm dot com>]

 It is Ok.  I tested your patch.  Can you please commit it to CVS?  Also 
Alexander Gottwald patches?  I am ttaching Alexander patches again.

Thanks
Suhaib

-----------------------
Hi, 
The following patch fixes an error with xdmcp where the parameter -class 
expected 2 arguments instead of only one. 

--- xdmcp.c.old Mon Apr 30 18:24:27 2001 
+++ xdmcp.c     Mon Apr 30 18:25:07 2001 
@@ -325,7 +325,6 @@ 
        return (i + 1); 
     } 
     if (strcmp(argv[i], "-class") == 0) { 
-       ++i; 
         if (++i == argc)  { 
            ErrorF("Xserver: missing class name in command line\n"); 
            exit(1); 





-----Original Message-----
From: Alan Hourihane
To: Suhaib Siddiqi
Cc: cygwin-xfree@sources.redhat.com
Sent: 4/30/2001 8:49 AM
Subject: Re: enlightenment & Eterm

On Mon, Apr 30, 2001 at 08:36:21AM -0400, Suhaib Siddiqi wrote:
> Alan,
> 
> Have also checked X11/X11-def.cpp and Xext/Xext-def.cpp?
> I do not have xc tree at my office PC.  I remember #ifdef outing some
XSHM
> export
> symbols with #ifdef __CYGWIN__ 
> Your dlls might be missing a few export symbols.  I do not remember
> what I used for #ifdef... I will check later tonight.
> 
Yes. I checked the Xext-def.cpp which has the correct symbols providing
the HAS_SHM is defined. That's what the HasShmDefines does on the end
of StandardDefines. libXext does get built correctly and exports the
right symbols with the patch.

I've not committed this. I'll wait for you to try too.

Alan.

xwin.diff