Re: cygwin_conv_path sometimes removes trailing slash

[Ray Donnelly <mingw dot android at gmail dot com>]

On Sun, Jan 31, 2016 at 11:38 AM, Jan Nijtmans <jan.nijtmans@gmail.com> wrote:
> 2016-01-30 4:21 GMT+01:00 Ken Brown:
>> I'm using cygwin_conv_path to convert Win32 paths to POSIX paths, and I'm
>> puzzled by the conversion
>>
>>   d:/ --> /cygdrive/d
>>
>> without the trailing slash.  By contrast, we have
>>
>>   d:/foo/ --> /cygdrive/d/foo/
>
> This came up before:
>    <https://cygwin.com/ml/cygwin/2015-10/msg00048.html>
> I had to workaround it in tkimg.
>
> It's easy to workaround in your program, but - indeed -
> that shouldn't be necessary. I too would expect that
> when the input contains a slash, the output should too.
>

I've attached the patch that we use on MSYS2 for this. We found
ourselves patching projects all over the open-source landscape
otherwise so fixing it once and for all seems sensible. Note however,
a full fix also requires another patch that I posted two years ago [1]
that Corinna chose not to apply. In the two years since, we've yet to
find any issue with that patch. I will rebase it shortly in-case
there's any interest in reconsidering it.

[1] https://cygwin.com/ml/cygwin-patches/2014-q1/msg00010.html

Best regards,

Ray Donnelly.

> Regards,
>      Jan Nijtmans
>
> --
> Problem reports:       http://cygwin.com/problems.html
> FAQ:                   http://cygwin.com/faq/
> Documentation:         http://cygwin.com/docs.html
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
>

Attachment: 0001-Don-t-remove-trailing-slash-from-root.patch
Description: Binary data

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple