[PATCH][BZ #14286] Fix integer overflow in vfwprintf.
Andreas Schwab
schwab@suse.de
Mon Oct 21 09:04:00 GMT 2013
OndÅej BÃlka <neleai@seznam.cz> writes:
> [BZ #14286]
> * stdio-common/vfprintf.c: Fix integer overflow.
s/Fix/Check for/
> diff --git a/stdio-common/vfprintf.c b/stdio-common/vfprintf.c
> index 8cd7a85..ba6b6d1 100644
> --- a/stdio-common/vfprintf.c
> +++ b/stdio-common/vfprintf.c
> @@ -1067,7 +1067,12 @@ vfprintf (FILE *s, const CHAR_T *format, va_list ap)
> /* Allocate dynamically an array which definitely is long \
> enough for the wide character version. Each byte in the \
> multi-byte string can produce at most one wide character. */ \
> - if (__libc_use_alloca (len * sizeof (wchar_t))) \
> + if (len > SIZE_MAX / sizeof (wchar_t)) \
> + { \
> + done = -1; \
> + goto all_done; \
You need to set errno. Use __glibc_unlikely.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
More information about the Libc-alpha
mailing list